Ramya Gnanasekar <quic_rgnanase@xxxxxxxxxxx> wrote: > During stress test with maximum VAPs and peer connected, below warning > is seen: > > [ 1079.110967] ath12k_pci 0004:01:00.0: mgmt tx queue is full > [ 1079.117708] ath12k_pci 0004:01:00.0: failed to queue management frame -28 > [ 1079.123191] ath12k_pci 0004:01:00.0: mgmt tx queue is full > [ 1079.129960] ath12k_pci 0004:01:00.0: failed to queue management frame -28 > [ 1079.135641] ath12k_pci 0004:01:00.0: mgmt tx queue is full > > This is caused by potential race condition while accessing skb_queue_len(). > When ath12k_mgmt_over_wmi_tx_work() and ath12k_mac_mgmt_tx() is called concurrently, > then skb_queue_len() might fetch list length which is modified by skb_queue_tail() > or skb_dequeue(). > > Replace skb_queue_len() with skb_queue_len_lockless() which will > prevent concurrent modified access using READ_ONCE(). And also use '>=', > in case we queue a few SKBs simultaneously. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthik M <quic_karm@xxxxxxxxxxx> > Signed-off-by: Ramya Gnanasekar <quic_rgnanase@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. e995f3f602a3 wifi: ath12k: fix potential wmi_mgmt_tx_queue race condition -- https://patchwork.kernel.org/project/linux-wireless/patch/20230419095758.19998-1-quic_rgnanase@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
