Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > The if statement is reversed so it will not record the chip version. > This was detected using Smatch: > > drivers/net/wireless/realtek/rtw89/core.c:3593 rtw89_read_chip_ver() > error: uninitialized symbol 'val'. > > Fixes: a6fb2bb84654 ("wifi: rtw89: read version of analog hardware") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. 9d4f491b860e wifi: rtw89: fix rtw89_read_chip_ver() for RTL8852B and RTL8851B -- https://patchwork.kernel.org/project/linux-wireless/patch/e4d912a2-37f8-4068-8861-7b9494ae731b@kili.mountain/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches