Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > From: Zong-Zhe Yang <kevin_yang@xxxxxxxxxxx> > > We have a pair of FW functions, rtw89_fw_h2c_add_pkt_offload() and > rtw89_fw_h2c_del_pkt_offload(). The rtw89_fw_h2c_add_pkt_offload() > acquires the bit itself, but the bit needs to be released by the > caller of rtw89_fw_h2c_del_pkt_offload(). This looks asymmetrical > and is not friendly to callers. > > Second, if callers always releases the bits, it might make driver > unaligned to bitmap status of FW after some failures of calling > rtw89_fw_h2c_del_pkt_offload(). So, this commit move bit release > into rtw89_fw_h2c_del_pkt_offload(). > > In general, driver will call rtw89_fw_h2c_add_pkt_offload() and > rtw89_fw_h2c_del_pkt_offload(), and then, SW bitmap can align > with FW one. There is one exception when notify_fw is false. > It happens when driver detects FW problems and is going to > reset FW. Only in this case, driver needs to release bits > outside rtw89_fw_h2c_del_pkt_offload(). > > Signed-off-by: Zong-Zhe Yang <kevin_yang@xxxxxxxxxxx> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> 5 patches applied to wireless-next.git, thanks. 25a7e5072ef1 wifi: rtw89: release bit in rtw89_fw_h2c_del_pkt_offload() 3ea1cd8d027f wifi: rtw89: refine packet offload delete flow of 6 GHz probe 8febd68be526 wifi: rtw89: packet offload wait for FW response 32bb12eb73dc wifi: rtw89: mac: handle C2H receive/done ACK in interrupt context b9b632f43f1c wifi: rtw89: scan offload wait for FW done ACK -- https://patchwork.kernel.org/project/linux-wireless/patch/8cf5d45c5b04e7b680d4eb9dda62056cdce14cec.camel@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
