On Fri, 2023-04-28 at 13:49 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> The parser expects values in hex.
> Syntax: aid color uldl enables
>
> The enables value is a set of flags to enable any/all of the
> aid, color, and/or uldl (in that order).
> options. For uldl, 0x1 means upload.
> Example, capture aid 11:
> echo "b 0 0 1" > /debug/ieee80211/phy0/mt76/he_sniffer_params
>
> Note that you must also enable the group-5 fields in the rx-status
> header for he-trig (and he-mu) to show up properly in a packet
> capture.
>
> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> ---
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h
> b/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h
> index 06f98e5cd95e..084001647aaa 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mt7915.h
> @@ -242,6 +242,13 @@ struct mt7915_phy {
> struct ieee80211_sband_iftype_data
> iftype[NUM_NL80211_BANDS][NUM_NL80211_IFTYPES];
>
> struct ieee80211_vif *monitor_vif;
> + u16 monitor_cur_aid; /* aid to be used in monitor mode to
> capture HE trigger frames */
> + /* bss-color to be used in monitor mode to capture HE trigger
> frames */
> + u8 monitor_cur_color;
> + /* upload/download to be used in monitor mode to capture HE
> trigger frames */
> + u8 monitor_cur_uldl;
> + /* Specifies which of the above are used: 0x1 is AID, 0x2 is
> color, 0x3 is uldl */
> + u8 monitor_cur_enables;
>
>
Just my personal taste to gather similar stuff into a struct.
struct {
u16 cur_aid;
u8 cur_uldl;
u8 cur_color
u8 cur_enabled;
} monitor;
Could you please make a change if you plan to post a v2?
Ryder
