On 4/28/23 13:41, Johannes Berg wrote:
On Fri, 2023-04-28 at 13:29 -0500, Larry Finger wrote:--- a/drivers/net/wireless/realtek/rtlwifi/core.c +++ b/drivers/net/wireless/realtek/rtlwifi/core.c @@ -1770,12 +1770,6 @@ static void rtl_op_flush(struct ieee80211_hw *hw, static int rtl_op_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set) { - struct rtl_priv *rtlpriv = rtl_priv(hw); - struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); - - if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192CU) - schedule_work(&rtlpriv->works.update_beacon_work); - return 0; }Looks like you could remove that entire method if it does nothing now, it doesn't matter to mac80211 if you have it or not (since you don't use AP_LINK_PS.) Not sure it matters to you in the driver :)
I thought about doing that, but decided to leave the empty one there until I could do more testing. Leaving it will add a few bytes to the driver, but that should not make much difference.
Larry
