Search Linux Wireless

RE: [PATCH] wifi: rtl8xxxu: Support new chip RTL8192FU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
> Sent: Wednesday, April 26, 2023 1:28 AM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Subject: [PATCH] wifi: rtl8xxxu: Support new chip RTL8192FU
> 
> This is a newer chip, similar to the RTL8710BU in that it uses the same
> PHY status structs.
> 
> Features: 2.4 GHz, b/g/n mode, 2T2R, 300 Mbps.
> 
> It can allegedly have Bluetooth, but that's not implemented here.
> 
> This chip can have many RFE (RF front end) types, of which type 5 is
> the only one tested. Many of the other types need different
> initialisation tables. They can be added if someone wants them.
> 
> The vendor driver v5.8.6.2_35538.20191028_COEX20190910-0d02 from
> https://github.com/BrightX/rtl8192fu was used as reference.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/Kconfig |    3 +-

It seems like you forget to add rtl8xxxu_8192f.o to Makefile.

>  .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h  |   47 +
>  .../realtek/rtl8xxxu/rtl8xxxu_8188f.c         |    3 +-
>  .../realtek/rtl8xxxu/rtl8xxxu_8192f.c         | 2081 +++++++++++++++++
>  .../realtek/rtl8xxxu/rtl8xxxu_8710b.c         |    1 +
>  .../realtek/rtl8xxxu/rtl8xxxu_8723b.c         |    1 +
>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c |  104 +-
>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h |   15 +
>  8 files changed, 2225 insertions(+), 30 deletions(-)
>  create mode 100644 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192f.c
> 

smatch reports two warnings that can be fixed by giving initial values: 

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192f.c:577 rtl8192fu_config_kfree() error: uninitialized symbol 'channel_idx'.
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192f.c:2027 rtl8192fu_led_brightness_set() error: uninitialized symbol 'ledcfg'.


I have not reviewed this patch entirely, and will continue in a few days.
Just let you know these problems ahead. 

Ping-Ke





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux