On Thu, Apr 20, 2023 at 04:50:34PM -1000, Tejun Heo wrote: > The conversions are from > > alloc_workqueue(WQ_UNBOUND | flags, 1, args..) > > to > > alloc_ordered_workqueue(flags, args...) > > which don't cause any functional changes. If you know that fully ordered > execution is not ncessary, please let me know. I'll drop the conversion and > instead add a comment noting the fact to reduce confusion while conversion > is in progress. > > If you aren't fully sure, it's completely fine to let the conversion > through. The behavior will stay exactly the same and we can always > reconsider later. > > As there are follow-up workqueue core changes, I'd really appreciate if the > patch can be routed through the workqueue tree w/ your acks. Thanks. > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> > Cc: Amitkumar Karwar <amitkarwar@xxxxxxxxx> > Cc: Ganapathi Bhat <ganapathi017@xxxxxxxxx> > Cc: Sharvari Harisangam <sharvari.harisangam@xxxxxxx> > Cc: Xinming Hu <huxinming820@xxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Paolo Abeni <pabeni@xxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > --- > .../net/wireless/marvell/mwifiex/cfg80211.c | 13 +++++------ > drivers/net/wireless/marvell/mwifiex/main.c | 22 +++++++++---------- > 2 files changed, 16 insertions(+), 19 deletions(-) These work queues only ever get a single work item on them, so "ordering" can't really matter. This could go either way -- a comment or the current patch; so: Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>
