On Wed, 2008-11-05 at 12:10 -0800, Luis R. Rodriguez wrote: > > Ok, checksums are nice to avoid having to memcmp large things, but > > afaict we're talking about maybe 12 bytes, right? > > Depends on the number of triplets, but since we only support 32 reg > rules this means we only support 32 triplets and therefore we only > support a max IE of size of 99 bytes (32 * 3 + 3). Realistically in JP > I expect there to be around 3, 4, or 5 or maybe even 6 triplets which > is 21 bytes. Alright, not so bad either though. > > If so, why don't we > > just keep a copy of the country IE and compare it fully every time? > > Eh. I'm inclined to leave the checksum then. We'd then have to bother > with freeing yet another thing later. Yeah, ok, I don't really care much, it just seemed the checksum complicated the code a bit. I guess much of that was due to the somewhat unnatural split between cfg80211 and mac80211 though. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part