Search Linux Wireless

Re: [PATCH 5/7] cfg80211: expect different rd in cfg80211 when intersecting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2008-11-05 at 11:55 -0800, Luis R. Rodriguez wrote:

> >>       /* This would make this whole thing pointless */
> >> -     BUG_ON(rd != cfg80211_regdomain);
> >> +     if (!last_request->intersect)
> >> +             BUG_ON(rd != cfg80211_regdomain);
> >>
> >>       /* update all wiphys now with the new established regulatory domain */
> >>       update_all_wiphy_regulatory(last_request->initiator);
> >>
> >> -     print_regdomain(rd);
> >> +     print_regdomain(cfg80211_regdomain);
> >
> > Maybe the printing here should be removed? It seems confusing now.
> 
> Well IMHO its correct to print it here as *this* is after its been set
> and passed through all wiphys. ACK?

Ah, hmm, rd is intersected before this, right? I think I just got
confused with the code flow, yeah, seems fine.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux