On 18/04/2023 04:13, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> >> Sent: Tuesday, April 18, 2023 1:08 AM >> To: linux-wireless@xxxxxxxxxxxxxxx >> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx> >> Subject: [PATCH 3/3] wifi: rtl8xxxu: Simplify setting the initial gain >> >> The goal of writing 0x6954341e / 0x6955341e to REG_OFDM0_XA_AGC_CORE1 >> appears to be setting the initial gain, which is stored in bits 0..6. >> Bits 7..31 are the same as what the phy init tables write. >> >> Modify only bits 0..6 so that we don't have to care about the values >> of the others. This way we don't have to add another "else if" for the >> RTL8192FU. >> >> Why we need to change the initial gain from the default 0x20 to 0x1e? >> Not sure. Some of the vendor drivers change it to 0x1e before scanning >> and then restore it to the original value after. > > When WiFi gets connected, it will try to adjust initial gain for target AP. > If we scan in this situation, change it to 0x1e to have better coverage to > find APs. > I see. I'll remember that if I implement the dynamic initial gain.