On Tue, 2023-04-18 at 17:27 +0800, Wen Gong wrote: > > Now lower driver I used do not store the key > Sure, that's fine. > and do not trigger > BSS_CHANGED_ASSOC for new links after assoc. I think you need to think hard about this ... whatever BSS_CHANGED_ASSOC causes is likely no longer correct in MLO. Again, the assoc state *itself* is only changed once, when the whole MLD associated. > So my suggestion is a way to active all links while assoc, this way is > simple for lower driver I used. Sure, and we do that. But that's not what you're asking - you're asking to re-do some *MLD* state when a new link is added, and I'm saying that it doesn't make sense to "add" (again) a key to the MLD that was already added, nor calling a vif (MLD!) level method saying the MLD changed state to associated (again). I really think you should solve this in the driver, that doesn't mean you have to _store_ he key, you can use one of the iteration functions as well. > Also ieee80211_set_active_links() is another way to active all links > after assoc. > Sure. johannes