> -----Original Message----- > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Sent: Monday, April 17, 2023 10:04 PM > To: linux-wireless <linux-wireless@xxxxxxxxxxxxxxx> > Cc: Hans Ulli Kroll <linux@xxxxxxxxxxxxx>; Larry Finger <Larry.Finger@xxxxxxxxxxxx>; Ping-Ke Shih > <pkshih@xxxxxxxxxxx>; Tim K <tpkuester@xxxxxxxxx>; Alex G . <mr.nuke.me@xxxxxxxxx>; Nick Morrow > <morrownr@xxxxxxxxx>; Viktor Petrenko <g0000ga@xxxxxxxxx>; Andreas Henriksson <andreas@xxxxxxxx>; > ValdikSS <iam@xxxxxxxxxxxxxxx>; kernel@xxxxxxxxxxxxxx; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Subject: [PATCH v3 3/4] wifi: rtw88: set pkg_type correctly for specific rtw8821c variants > > According to the vendor driver the pkg_type has to be set to '1' > for some rtw8821c variants. As the pkg_type has been hardcoded to > '0', add a field for it in struct rtw_hal and set this correctly > in the rtw8821c part. > With this parsing of a rtw_table is influenced and check_positive() > in phy.c returns true for some cases here. The same is done in the > vendor driver. However, this has no visible effect on the driver > here. I agree this patch, but still want to know more about the meaning of "...no visible effect...". Do you mean your USB device works well with/without this patch? or, IO is absolutely the same when loading parameters with check_positive()? > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> [..]
