On Mon, Apr 17, 2023 at 04:01:30PM +0200, Sascha Hauer wrote: > Third round of the RTW88 USB bug fixes. > > After some discussion and thinking I came to the conclusion that the > v1 variant of "wifi: rtw88: rtw8821c: Fix rfe_option field width" is > better than the one posted in v2, so I reverted back to this version, > but added a note to the commit message why this might not be entirely > correct for all chip variants (though for all variants currently > supported in the driver). > > The patches are sorted in order of importance. 1/4 hasn't seen any > negative comments and I think it should be applied right now. > As stated above I think 2/4 should be applied as well. 3/4 fixes > something I stumbled upon while reading in the vendor driver, but > I don't what effect it actually has, I didn't notice any change > in behaviour of the driver. 4/4 straightens the logic how > rtw8821c_switch_rf_set() is called for different variants of the > rtw8821c. This is taken from the vendor driver. From the supported > chip variants this should only have an effect on the ones with > rfe_option = 6, but I don't have that one available here for > testing. > > I would be glad if at least 1/4 and 2/4 could be applied as these > fix real issues in the driver. Please ignore. There was a typo in Larrys email address, I am resending the whole series. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |