Li Ningke <lnk_01@xxxxxxxxxxx> wrote: > Smatch complains that > drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe() warn: > missing unwind goto? > > In order to release the allocated resources before returning an > error, the statement that directly returns the error is changed > to a goto statement that first releases the resources in the error > handling section. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Signed-off-by: Li Ningke <lnk_01@xxxxxxxxxxx> > Reviewed-by: Dongliang Mu <dzm91@xxxxxxxxxxx> Already fixed with an identical patch: https://git.kernel.org/kvalo/ath/c/488d9a484f96 error: patch failed: drivers/net/wireless/ath/ath12k/pci.c:1195 error: drivers/net/wireless/ath/ath12k/pci.c: patch does not apply stg import: Diff does not apply cleanly Patch set to Rejected. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230417115921.176229-1-lnk_01@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches