On 4/14/23 08:28, Kalle Valo wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> <Amisha.Patel@xxxxxxxxxxxxx> wrote:
>
>> Enable the RSN flag to pass cipher suite and AMK information, even when
>> RSN capabilities field not present (as it's optional).
>>
>> Fixes: cd21d99e595e ("wifi: wilc1000: validate pairwise and authentication suite offsets")
>> Signed-off-by: Amisha Patel <amisha.patel@xxxxxxxxxxxxx>
>
> The commit log should always answer to "Why?". What issue does this fix?
>
Mandatory WFA testcase
CT_Security_WPA2Personal_STA_RSNEBoundsVerfication-AbsentRSNCap,
performs bounds verification on Beacon and/or Probe response frames. It
failed and observed the reason to be absence of cipher suite and AKM
suite in RSN information. Enable the RSN flag before extracting RSN
capabilities fixes the issue.
I'll resubmit the patch v2 with new commit log.
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/20230405173555.6041-1-amisha.patel@xxxxxxxxxxxxx/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
