Search Linux Wireless

Re: [RFC/RFT PATCH 0/2] rtl8187: implement conf_tx callback/correctly ack tx pkts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> if (condition)
>     info->flags |= IEEE80211_TX_STAT_ACK;
> else 
>     info->status.excessive_retries = 1;
> ---------------
> 
> But the else-clause is missing in the latest patch (of two), which also seems to be where both you and Larry are having rate stuck at 1Mb/s for.
> - and the line below
> "info->status.rates[0].count = pkt_rc +1 ;" doesn't compile
> under 2.6.27, so I changed the rates[0].count to the retry_count,
> and simultaneously adding the else-clause back. 
> 
> My question is this: is the removal of the else-clause unintensional,
> could it result in your 1Mb/s rate?

The excessive_retries status thing has been removed and mac80211 ought
to always use STAT_ACK now.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux