> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Wednesday, March 29, 2023 2:21 PM > To: Rafael J. Wysocki <rafael@xxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; > Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>; Lars-Peter Clausen > <lars@xxxxxxxxxx>; Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>; > Jonathan Cameron <jic23@xxxxxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; > David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet > <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni > <pabeni@xxxxxxxxxx>; Jiri Slaby <jirislaby@xxxxxxxxxx>; Thierry Reding > <thierry.reding@xxxxxxxxx>; Jonathan Hunter <jonathanh@xxxxxxxxxx>; Marc > Zyngier <maz@xxxxxxxxxx> > Cc: linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > staging@xxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; linux- > tegra@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Subject: [PATCH 0/5] Remove acpi.h implicit include of of.h > > In the process of cleaning up DT includes, I found that some drivers > using DT functions could build without any explicit DT include. I traced > the include to be coming from acpi.h via irqdomain.h. > > I was pleasantly surprised that there were not 100s or even 10s of > warnings when breaking the include chain. So here's the resulting > series. > > I'd suggest Rafael take the whole series. Alternatively,the fixes can be > applied in 6.4 and then the last patch either after rc1 or the > following cycle. > Nice that there aren't too many errors. Use of the forward declarations makes sense rather than including a bunch of unrelated definitions. Nice. Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx> Thanks, Jake > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > Rob Herring (5): > iio: adc: ad7292: Add explicit include for of.h > staging: iio: resolver: ad2s1210: Add explicit include for of.h > net: rfkill-gpio: Add explicit include for of.h > serial: 8250_tegra: Add explicit include for of.h > ACPI: Replace irqdomain.h include with struct declarations > > drivers/iio/adc/ad7292.c | 1 + > drivers/staging/iio/resolver/ad2s1210.c | 1 + > drivers/tty/serial/8250/8250_tegra.c | 1 + > include/linux/acpi.h | 4 +++- > net/rfkill/rfkill-gpio.c | 1 + > 5 files changed, 7 insertions(+), 1 deletion(-) > --- > base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6 > change-id: 20230329-acpi-header-cleanup-665331828436 > > Best regards, > -- > Rob Herring <robh@xxxxxxxxxx>