Search Linux Wireless

Re: [PATCH] p54: don't report known but unhandled EEPROM codes as unknown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-10-30 at 18:10 +0100, Chr wrote:
> On Wednesday 29 October 2008 22:31:43 Pavel Roskin wrote:
> > [...]
> > +		case PDR_RADIATED_TRANSMISSION_CORRECTION:
> > +		case PDR_PRISM_TX_IQ_CALIBRATION:
> > +		case PDR_BASEBAND_REGISTERS:
> > +		case PDR_PER_CHANNEL_BASEBAND_REGISTERS:
> > +			break;
> >  		default:
> >  			printk(KERN_INFO "p54: unknown eeprom code : 0x%x\n",
> >  				le16_to_cpu(entry->code));
> 
> what about removing the printk?
> since intersil reserved 0x8000-0xffff for it's customers...
> so there could be lots of unknown pdr magics.

I don't see any extra messages.  From my experience, OEMs don't change
anything except the required settings (IDs, OEM name, country code) and
don't add anything non-trivial.

But I'm fine either way, with or without that printk.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux