On 3/27/2023 5:04 PM, Johannes Berg wrote:
On Mon, 2023-03-27 at 16:40 +0800, Wen Gong wrote:
+ for_each_set_bit(link_id, &add, IEEE80211_MLD_MAX_NUM_LINKS) {
+ struct ieee80211_link_data *link;
+
+ link = sdata_dereference(sdata->link[link_id], sdata);
+
+ ret = ieee80211_link_use_channel(link, &link->conf->chandef,
+ IEEE80211_CHANCTX_SHARED);
For the 1st link of MLO connection/NON-MLO connetion, ieee80211_link_use_channel() is called before drv_change_sta_link(),
And now it is after drv_change_sta_link(), May I know is it also has some design here?
Hmm, probably not really, at least I don't remember anything about that.
Not sure it makes a huge difference? But I suppose we could change it, I
don't really see why not either.
Not huge difference, I have made little change in lower-driver to match
that. So it is OK now.
OK. Still maybe we should change it for consistency? I can try that
later with our driver.
johannes
I think it is not urgent for that:)
And lower-drvier should also handler different case.
