> -----Original Message-----
> From: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx>
> Sent: Thursday, March 23, 2023 1:19 AM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; Ping-Ke Shih
> <pkshih@xxxxxxxxxxx>; Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>; Sebastian Andrzej Siewior
> <bigeasy@xxxxxxxxxxxxx>
> Subject: [RFC PATCH 13/14] wifi: rtl8xxxu: Clean up filter configuration
>
> In AP mode, RCR_CHECK_BSSID_MATCH should not be set. Rearrange RCR bits
> to filter flags to match other realtek drivers and don't set
> RCR_CHECK_BSSID_BEACON and RCR_CHECK_BSSID_MATCH in AP mode.
>
> Signed-off-by: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx>
> ---
> .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 82fbe778fc5ec..b6f811ad01333 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -6597,23 +6597,24 @@ static void rtl8xxxu_configure_filter(struct ieee80211_hw *hw,
> * FIF_PLCPFAIL not supported?
> */
>
> - if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
> - rcr &= ~RCR_CHECK_BSSID_BEACON;
> - else
> - rcr |= RCR_CHECK_BSSID_BEACON;
> + if (priv->vif->type != NL80211_IFTYPE_AP) {
I think mac80211 configure filters depends on operating conditions, so it would
be possible to avoid checking vif->type.
> + if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
> + rcr &= ~(RCR_CHECK_BSSID_BEACON | RCR_CHECK_BSSID_MATCH);
> + else
> + rcr |= RCR_CHECK_BSSID_BEACON | RCR_CHECK_BSSID_MATCH;
> + } else {
> + rcr &= ~RCR_CHECK_BSSID_MATCH;
> + }
>
> if (*total_flags & FIF_CONTROL)
> rcr |= RCR_ACCEPT_CTRL_FRAME;
> else
> rcr &= ~RCR_ACCEPT_CTRL_FRAME;
>
> - if (*total_flags & FIF_OTHER_BSS) {
> + if (*total_flags & FIF_OTHER_BSS)
> rcr |= RCR_ACCEPT_AP;
> - rcr &= ~RCR_CHECK_BSSID_MATCH;
> - } else {
> + else
> rcr &= ~RCR_ACCEPT_AP;
> - rcr |= RCR_CHECK_BSSID_MATCH;
> - }
>
> if (*total_flags & FIF_PSPOLL)
> rcr |= RCR_ACCEPT_PM;
> --
> 2.30.2
