Hi Maharaja, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-next/main] [also build test WARNING on kvalo-ath/ath-next next-20230320] [cannot apply to wireless/main linus/master v6.3-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Maharaja-Kennadyrajan/wifi-nl80211-rename-NL80211_CMD_SET_BEACON-to-NL80211_CMD_UDPATE_AP/20230321-005501 base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main patch link: https://lore.kernel.org/r/20230320164334.3325886-5-quic_mkenna%40quicinc.com patch subject: [PATCH v2 4/4] wifi: ath11k: add AP power save support config: i386-buildonly-randconfig-r006-20230320 (https://download.01.org/0day-ci/archive/20230321/202303210807.4SdWf5Ix-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/289c49facf48da5a221a3c8072f97c4641eca9f0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Maharaja-Kennadyrajan/wifi-nl80211-rename-NL80211_CMD_SET_BEACON-to-NL80211_CMD_UDPATE_AP/20230321-005501 git checkout 289c49facf48da5a221a3c8072f97c4641eca9f0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/wireless/ath/ath11k/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303210807.4SdWf5Ix-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/net/wireless/ath/ath11k/mac.c:3218:6: warning: no previous prototype for function 'ath11k_mac_ap_ps_recalc' [-Wmissing-prototypes] void ath11k_mac_ap_ps_recalc(struct ath11k *ar) ^ drivers/net/wireless/ath/ath11k/mac.c:3218:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void ath11k_mac_ap_ps_recalc(struct ath11k *ar) ^ static 1 warning generated. vim +/ath11k_mac_ap_ps_recalc +3218 drivers/net/wireless/ath/ath11k/mac.c 3217 > 3218 void ath11k_mac_ap_ps_recalc(struct ath11k *ar) 3219 { 3220 struct ath11k_vif *arvif; 3221 enum ath11k_ap_ps_state state = ATH11K_AP_PS_STATE_OFF; 3222 int ret; 3223 bool allow_ap_ps = true; 3224 3225 lockdep_assert_held(&ar->conf_mutex); 3226 3227 list_for_each_entry(arvif, &ar->arvifs, list) { 3228 if (arvif->vdev_type == WMI_VDEV_TYPE_STA || 3229 !arvif->vif_ap_ps_enabled) { 3230 allow_ap_ps = false; 3231 break; 3232 } 3233 } 3234 3235 if (!allow_ap_ps) 3236 ath11k_dbg(ar->ab, ATH11K_DBG_MAC, "ap ps is not allowed\n"); 3237 3238 if (allow_ap_ps && !ar->num_stations && ar->ap_ps_enabled) 3239 state = ATH11K_AP_PS_STATE_ON; 3240 3241 if (ar->ap_ps_state == state) 3242 return; 3243 3244 ret = ath11k_wmi_pdev_ap_ps_cmd_send(ar, ar->pdev->pdev_id, state); 3245 if (ret) { 3246 ath11k_dbg(ar->ab, ATH11K_DBG_MAC, 3247 "failed to send ap ps command pdev_id %u state %u\n", 3248 ar->pdev->pdev_id, state); 3249 return; 3250 } 3251 3252 ar->ap_ps_state = state; 3253 } 3254 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
