On Mon, Mar 20, 2023 at 02:18:31PM +0200, Kalle Valo wrote: > Johan Hovold <johan@xxxxxxxxxx> writes: > >> > > + qcom,ath11k-calibration-variant = "LE_X13S"; > >> > Intentional? Especially given Kalle's comment on bugzilla? > >> > >> Yes, it is intentional. The corresponding calibration data allows the > >> wifi to be used on the CRD. I measure 150 MBits/s which may a bit lower > >> than expected, but it's better than having no wifi at all. > > > > I was going back and forth about mentioning this in the commit message > > and we could off on this one until someone confirms that the > > corresponding calibration data can (or should) be used for the X13s. Hopefully clear from context, but that was supposed to say "CRD" and not "X13s"... > > Note that there is no other match for > > > > 'bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=140' > > > > in the new board-2.bin. > > If the device in question is something else than Lenovo X13s, I would > prefer that the variant is not set. Just in case we need different board > files for different models. It's easy to add aliases to board-2.bin. The sc8280xp CRD is the Qualcomm "compute" reference design for this platform and is very similar to the X13s but they are not identical. For ath11k and wcn6855, the CRD I have reports a chip_id of 2 and "hw2.0", while the X13s reports chip_id 18 and "hw2.1". The new board-2.bin notably adds two entries that match these chip_ids but with the variant specified as "LE_X13S" for both. > I need to check internally what board file should be used for this CRD. > If the speed is only 150 Mbit/s I suspect it needs a different board > file. Sounds good. Let's drop this one for now then. Johan
