On Tue, 2023-03-07 at 11:08 +0100, Johannes Berg wrote: > On Sat, 2023-02-18 at 01:49 +0800, Ryder Lee wrote: > > This is utilized to pass LDPC configurations from user space > > (i.e. hostapd) to driver. > > > > I'm applying this, but could you do me a favour and check that we > really > don't need to reset this? What if we added a previous BSS with e.g. > VHT > and then reconfigure the interface to w/o VHT and then the settings > might stick? > > More generally, it might be worth checking if we can just memset the > entire bss_conf to 0? We already do this for link conf today (always > reallocate it) so it should be OK? Same actually goes for client mode > so > maybe we can generally clean that up? > I agree, and myabe this is a long standing issue. I think we need a fresh start for bss_conf. I've seen this case: hostapd would pass fils_interval only if (param->fils_interval), so if someone tries to disable it by "0" which doesn't work. Kernel should ptotect such case. Ryder
