> -----Original Message----- > From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > Sent: Saturday, March 11, 2023 1:53 AM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx > Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Jiajie Chen <c@xxxxxx> > Subject: Re: [PATCH v2] wifi: rtl8xxxu: Support new chip RTL8710BU aka RTL8188GU > > On 10/03/2023 02:49, Ping-Ke Shih wrote: > > > > 2. drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8710b.c:1487 rtl8710bu_phy_iq_calibrate() error: > uninitialized symbol 'reg_e94'. > > > > This could be a false-alarm too. 'reg_e94' must be set if 'candidate >= 0', but > > original statement causes smatch hard to determine: > > > > if (reg_e94 && candidate >= 0) > > > > swap the expressions to fix the warning: > > > > if (candidate >= 0 && reg_e94) > > > > Moving "if (reg_e94)" inside the previous "if (candidate >= 0)" should also > fix it, I think. > > if (candidate >= 0) { > reg_e94 = result[candidate][0]; > reg_e9c = result[candidate][1]; > reg_ea4 = result[candidate][2]; > reg_eac = result[candidate][3]; > > dev_dbg(dev, "%s: candidate is %x\n", __func__, candidate); > dev_dbg(dev, "%s: e94=%x e9c=%x ea4=%x eac=%x\n", > __func__, reg_e94, reg_e9c, reg_ea4, reg_eac); > > path_a_ok = true; > > if (reg_e94) > rtl8xxxu_fill_iqk_matrix_a(priv, path_a_ok, result, > candidate, (reg_ea4 == 0)); > } > Indeed, I have confirmed it works.