Hello Hector Martin,
The patch 0f485805d008: "wifi: brcmfmac: acpi: Add support for
fetching Apple ACPI properties" from Feb 14, 2023, leads to the
following Smatch static checker warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c:22 brcmf_acpi_probe()
warn: passing negative value to 'ACPI_FAILURE((-71))'
drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c
11 void brcmf_acpi_probe(struct device *dev, enum brcmf_bus_type bus_type,
12 struct brcmf_mp_device *settings)
13 {
14 acpi_status status;
15 const union acpi_object *o;
16 struct acpi_buffer buf = {ACPI_ALLOCATE_BUFFER, NULL};
17 struct acpi_device *adev = ACPI_COMPANION(dev);
18
19 if (!adev)
20 return;
21
--> 22 if (!ACPI_FAILURE(acpi_dev_get_property(adev, "module-instance",
23 ACPI_TYPE_STRING, &o))) {
This doesn't affect run time, but acpi_dev_get_property() does not
return ACPI error codes, it returns normal kernel error codes.
24 brcmf_dbg(INFO, "ACPI module-instance=%s\n", o->string.pointer);
25 settings->board_type = devm_kasprintf(dev, GFP_KERNEL,
26 "apple,%s",
27 o->string.pointer);
28 } else {
29 brcmf_dbg(INFO, "No ACPI module-instance\n");
30 return;
31 }
regards,
dan carpenter
