> > > @@ -3186,6 +3218,7 @@ struct hwsim_new_radio_params { > > u32 *ciphers; > > u8 n_ciphers; > > bool mlo; > > + const struct cfg80211_pmsr_capabilities *pmsr_capa; > > nit: not related to this patch, > but there are lots of holes in hwsim_new_radio_params. > And, I think that all fields, other than the new pmsr_capa field, > could fit into one cacheline on x86_64. > > I'm unsure if it is worth cleaning up or not. > Probably not. It's just a temporary thing there, I don't think we even have it for longer than temporarily on the stack. johannes