On Saturday 01 November 2008, Johannes Berg wrote: > On Sat, 2008-11-01 at 16:25 +0100, Ivo van Doorn wrote: > > On Saturday 01 November 2008, Johannes Berg wrote: > > > On Sat, 2008-11-01 at 11:29 +0100, Ivo van Doorn wrote: > > > > On Saturday 01 November 2008, Johannes Berg wrote: > > > > > On Sat, 2008-11-01 at 09:58 +0100, Ivo van Doorn wrote: > > > > > > > > > > > Could you try this patch? It doesn't matter if it is on top or as a replacement > > > > > > of my previous patch. > > > > > > > > > > > > This patch should also fix suspend/resume handling in general, I suddenly realized > > > > > > there was quite a big bug in there regarding EEPROM/CSR handling. > > > > > > > > > > Now it just hangs at resume, rather than crashing. At suspend it already > > > > > logs some MCU errors though. > > > > > > > > Hmm that is strange, those MCU errors could only come from right before the code I > > > > just changed. :S > > > > > > > > In any case, could you revert the previous patches and try this. This is the same LED patch > > > > as before, but I have added the check for set_key() to return immediately when this is called > > > > while the module is busy unloading. > > > > > > Now I've upgraded wireless-testing and am running into the BUG_ON you > > > added for antenna diversity... > > > > Hmm, that's odd.. I'll look into it. Patches could take some time :( > > That was with that patch applied, but I don't think it caused it. No > worries, I don't usually actually use the rt61 card, but had used it for > monitoring the night before I wrote my bug report, suspended, and > ejected it while suspended the next morning because I had to run... :) I think I found something, I'm sending a patch series for John in a few minutes, it will contain a fix for this BUG_ON(). Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
