On Tue, 2023-02-28 at 08:29 +0200, Kalle Valo wrote: > Dan Williams <dcbw@xxxxxxxxxx> writes: > > > On Mon, 2023-02-27 at 21:11 +0200, Kalle Valo wrote: > > > Dan Williams <dcbw@xxxxxxxxxx> writes: > > > > > > > On Mon, 2023-02-27 at 14:17 +0200, Kalle Valo wrote: > > > > > To clean up drivers/net/wireless move the old drivers drivers > > > > > left in > > > > > the > > > > > directory to a new "legacy" directory. I did consider adding > > > > > CONFIG_WLAN_VENDOR_LEGACY like other vendors have but then > > > > > dropped > > > > > the idea as > > > > > these are really old drivers and hopefully we get to remove > > > > > them > > > > > soon. > > > > > > > > Why is rndis_wlan legacy? It supports devices that are way > > > > newer > > > > than > > > > ray_cs or wl3501... like this Linksys WUSB54GSC from late 2007: > > > > > > > > [1086339.589565] rndis_wlan 1-3:1.0 wlan0: register > > > > 'rndis_wlan' at > > > > usb-0000:00:14.0-3, Wireless RNDIS device, BCM4320b based, > > > > 00:1d:7e:9e:2f:bb > > > > [1086339.589961] usbcore: registered new interface driver > > > > rndis_wlan > > > > > > So you have this device? Does it work? I think I should make a > > > table > > > somewhere for these old drivers with last success reports :) > > > > Yep, I have it, it works. Needless to say, I don't *use* it. > > Yeah, I guessed that part :) But thanks for testing, good to know it > works. > > > > > Dunno, just seems a completely different class of devices than > > > > old > > > > 802.11b-only PCMCIA ones... > > > > > > I was about to say that all drivers using Wireless Extensions are > > > legacy, but to my surprise rndis_wlan actually uses cfg80211 :) > > > > > > I put this to "legacy" as I didn't find any better location and > > > adding a > > > new vendor driver just for rndis_wlan felt like overkill. The > > > directory > > > name "legacy" is just a name, it has no real meaning and users > > > won't > > > see > > > it either. It could be "misc", "old" or something else as well. > > > > Is the goal just to get all the .c individual drivers out of > > net/wireless? > > Yes, exactly. The extra files in drivers/net/wireless annoy me > everytime > when I'm checking something in the tree. ray_cs and wl3501_cs are also PCMCIA drivers (not CardBus) and isn't Arnd trying to get rid of PCMCIA via "[RFC 0/6] pcmcia: separate 16-bit support from cardbus"? Maybe those two drivers get solved for you :) > > Also isn't Greg KH out to kill RNDIS too? I don't recall that being > > a > > settled question yet, but I lost track. > > I haven't heard anything about that recently, I hope we don't have to > remove rndis_wlan from the tree. But wext drivers are another thing, > we > really should get rid of them (or convert to cfg80211). I have vague, morbid interest in converting atmel and prism54 to cfg80211 but timeline on that would be "this year". Dan