On Fri, 2023-02-24 at 00:38 +0900, Jaewan Kim wrote: > > > > > > +int cfg80211_send_chandef(struct sk_buff *msg, const struct cfg80211_chan_def *chandef); > > > > I think it'd be better if you exported it as nl80211_..., since it > > really is just a netlink thing, not cfg80211 functionality. > > Sorry about the late response but could you elaborate to me in more > detail on this? > Where header file would be the good place if it's exporting it as nl80211_...? Oh, same header file, just with a different function name prefix. nl80211 is part of cfg80211 anyway, but having it nl80211_ will make it clearer (IMHO) that it does stuff related to netlink. > net/wireless/nl80211.h seems like your suggestion, but I can't find > how to include this from mac80211_hwsim.c. That's just an internal header. Leave it here, but I think we could rename it. johannes
