> On 24-Feb-2023, at 6:42 PM, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Aditya Garg <gargaditya08@xxxxxxxx> writes: > >> On 23-Feb-2023, at 8:31 PM, Aditya Garg <gargaditya08@xxxxxxxx> wrote: >> >> Hi Hector >> >> I’ve applied the following patchset (arranged in chronological order) to linux 6.2, >> and wifi seems to have broken on MacBookPro16,1 (brcmfmac4364b3) >> >> https://lore.kernel.org/asahi/20230212063813.27622-1-marcan@xxxxxxxxx/T/#t >> (BCM4355/4364/4377 support & identification fixes) >> >> https://lore.kernel.org/asahi/20230214080034.3828-1-marcan@xxxxxxxxx/T/#t (Apple T2 >> platform support) >> >> https://lore.kernel.org/asahi/20230214091651.10178-1-marcan@xxxxxxxxx/T/#t (BCM4387 >> / Apple M1 platform support) >> >> https://lore.kernel.org/asahi/b4489e24-e226-4f99-1322-cab6c1269f09@xxxxxxxxxxxx/T/#t >> (brcmfmac: cfg80211: Use WSEC to set SAE password) >> >> The logs show: >> >> Feb 23 20:08:57 MacBook kernel: usbcore: registered new interface driver brcmfmac >> Feb 23 20:08:57 MacBook kernel: brcmfmac 0000:05:00.0: enabling device (0000 -> 0002) >> Feb 23 20:08:57 MacBook kernel: brcmfmac: brcmf_fw_alloc_request: using >> brcm/brcmfmac4364b3-pcie for chip BCM4364/4 >> Feb 23 20:08:57 MacBook kernel: brcmfmac 0000:05:00.0: Direct firmware load for >> brcm/brcmfmac4364b3-pcie.Apple Inc.-MacBookPro16,1.bin failed with error -2 >> Feb 23 20:08:57 MacBook kernel: brcmfmac 0000:05:00.0: Direct firmware load for >> brcm/brcmfmac4364b3-pcie.bin failed with error -2 >> Feb 23 20:08:57 MacBook kernel: brcmfmac 0000:05:00.0: brcmf_pcie_setup: Dongle setup >> failed >> >> I also tested the patchiest in the following link, and wifi mostly worked there (occasionally it >> complained about some pic error, I’ll save the logs next time I encounter that) : >> >> https://github.com/t2linux/linux-t2-patches/blob/main/8001-asahilinux-wifi-patchset.patch >> >> Thanks >> Aditya >> >> I just noticed that the patch to ACPI was missing. Adding that fixed the issue. >> >> https://github.com/t2linux/linux-t2-patches/blob/main/8005-ACPI-property-Support-strings-in-Apple-_DSM-props.patch > > Please don't use HTML, our lists drop those. I'll reply in text/plain so > that is info is archived. > Hi Sorry for that. I actually forgot to format that email as plain text. > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
