Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > Intentionally parsing single one element of RA report by breaking loop > causes a smatch warning: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c:1678 rtl8188e_handle_ra_tx_report2() warn: > ignoring unreachable code. > > With existing comments, it intends to process single one element for > station mode, but it will parse more elements in AP mode if it's > implemented. Implement program logic according to existing comment to avoid > smatch warning, and also be usable for both AP and stations modes. > > Compile test only. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Link: https://lore.kernel.org/r/202302142135.LCqUTVGY-lkp@xxxxxxxxx/ > Cc: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Tested-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> Patch applied to wireless-next.git, thanks. 398eb19415eb wifi: rtl8xxxu: 8188e: parse single one element of RA report for station mode -- https://patchwork.kernel.org/project/linux-wireless/patch/20230216004654.4642-1-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
