> -----Original Message----- > From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > Sent: Saturday, February 18, 2023 2:49 AM > To: linux-wireless@xxxxxxxxxxxxxxx > Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Subject: [PATCH] wifi: rtl8xxxu: Remove always true condition in rtl8xxxu_print_chipinfo > > Fix a new smatch warning: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1580 rtl8xxxu_print_chipinfo() warn: always true > condition '(priv->chip_cut <= 15) => (0-15 <= 15)' > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Link: https://lore.kernel.org/oe-kbuild-all/202302140753.71IgU77A-lkp@xxxxxxxxx/ > Fixes: 7b0ac469e331 ("wifi: rtl8xxxu: Recognise all possible chip cuts") > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > index 620a5cc2bfdd..54ca6f2ced3f 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > @@ -1575,11 +1575,7 @@ rtl8xxxu_set_spec_sifs(struct rtl8xxxu_priv *priv, u16 cck, u16 ofdm) > static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv) > { > struct device *dev = &priv->udev->dev; > - char cut = '?'; > - > - /* Currently always true: chip_cut is 4 bits. */ > - if (priv->chip_cut <= 15) > - cut = 'A' + priv->chip_cut; > + char cut = 'A' + priv->chip_cut; > > dev_info(dev, > "RTL%s rev %c (%s) romver %d, %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n", > -- > 2.39.1 > > ------Please consider the environment before printing this e-mail.
