On Friday, 31 of October 2008, Andrey Borzenkov wrote: > On Friday 31 October 2008, David Kilroy wrote: > > When preparing for either suspend or hibernation, load the necessary > > firmware from userspace. > > > > Upon error or resume, release the firmware. > > > > Works for both Agere and Symbol firmware. > > > > Signed-off by: David Kilroy <kilroyd@xxxxxxxxx> > > This is on top of my old patch; was it ever accepted anywhere? I guess > it should be rediffed against clean tree. > > > @@ -621,7 +620,7 @@ symbol_dl_image(struct orinoco_private *priv, const struct fw_info *fw, > > ret = hermes_init(hw); > > > > /* hermes_reset() should return 0 with the secondary firmware */ > > - if (secondary && ret != 0) > > + if (secondary && (ret != 0)) > > Extra parenthesis are redundant, are not they? > > > /********************************************************************/ > > +/* Power management */ > > +/********************************************************************/ > > + > > +static int orinoco_pm_notifier(struct notifier_block *notifier, > > + unsigned long pm_event, > > + void *unused) > > It probably should be conditional on CONFIG_PM somehow? CONFIG_PM_SLEEP, actually. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
