On Tue, Oct 21, 2008 at 04:13:47PM -0400, Dan Williams wrote: > On Mon, 2008-10-20 at 16:49 -0700, Anna Neal wrote: > > View README for new API. > > > > This patch implements the userspace interface for fine-grained configuration of > > wake-on-(w)lan. We are aware that iwpriv's are discouraged, but this is a > > vendor-specific feature that's currently being used in the OLPC project. > > > > We are aware that all iwprivs were removed from this driver. These used the old > > API for iwprivs. We've implemented this iwpriv as a private handler which relies > > on wireless extensions to do bounds checking and copying to/from user memory. > > Specific suggestions on how to make this more palatable for upstream inclusion > > are welcome. If iwprivs are completely unacceptable then this can serve as a > > public reference for interfacing with these features. > > IMHO we should be adding the functionality where's it's needed, which is > that ethtool, which doesn't have a verbose enough syntax for it's WOL > support. If ethtool's existing WOL got fixed up to support these > use-cases, then we wouldn't need iwpriv commands, we wouldn't have > duplicate functionality running around, and everyone gets a pony. Lets > kick off that discussion... > > Jeff: could something like this syntax be added to ethtool, or maybe > discreet commands instead of one? Thoughts? Did anything come out of this discussion? I'd prefer not to add new iwpriv stuff... John -- John W. Linville Linux should be at the core linville@xxxxxxxxxxxxx of your literate lifestyle. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html