On Fri, 2023-02-17 at 14:11 +0900, Jaewan Kim wrote:
> >
> > > +static const struct nla_policy
> > > +hwsim_ftm_capa_policy[NL80211_PMSR_FTM_CAPA_ATTR_MAX + 1] = {
> >
> > This feels a bit iffy to have here, but I guess it's better that
> > defining new attributes for all this over and over again.
>
> I'm sorry but could you rephrase what you expect here?
> Are you suggesting to define new sets of HWSIM_PMSR_* enums
> instead of using existing enums NL80211_PMSR_*?
No, I was just drive-by commenting on this. Given all the options this
feels like it's probably the best one :-)
> BTW, can I expect you to review my changes for further patchsets?
> I sometimes get conflicting opinions (e.g. line limits)
Sorry about that. See my other mail. I'm happy to accept it as it is.
> so it would be a great help if you take a look at my changes.
>
I'll be the one applying the patches, so yes.
johannes
