On Wed, 2023-02-01 at 12:26 +0530, Rameshkumar Sundaram wrote: > As per 802.11ax-2021, STAs shall process BSS Color Change Announcement > (BCCA) from AP and switch to new color, but some STAs aren't processing > BCCA from AP and not doing color switch, causing them to drop data > frames from AP post color change. Hmm. We had this bug in EHT. Should we really allow this? It's a station bug, why bother? > Provide an option to disable color collision detection and therefore > not to do BCCA to mitigate the same from AP. If it's required in case > where STA supports BCCA handling, then it can enabled in AP using this > option. This could be rewritten a bit, not entirely clear to me. "enabled" is more like "disabled"? Or no? Confusing. > + * @NL80211_HE_BSS_COLOR_ATTR_COLLISION_DETECTION_DISABLED: is BSS > + * color collision detection disabled. please use a tab to indent the second line like elsewhere > + he_bss_color->collision_detection_enabled = > + !nla_get_flag(tb[NL80211_HE_BSS_COLOR_ATTR_COLLISION_DETECTION_DISABLED]); Is it really worth to have one side say "enabled" and the other "disabled"? johannes
