On Wed, Feb 15, 2023 at 07:35:09AM +0200, Kalle Valo wrote: > Marc Bornand <dev.mbornand@xxxxxxxxxx> writes: > > > changes since v3: > > - add missing NULL check > > - add missing break > > > > changes since v2: > > - The code was tottaly rewritten based on the disscution of the > > v2 patch. > > - the ssid is set in __cfg80211_connect_result() and only if the ssid is > > not already set. > > - Do not add an other ssid reset path since it is already done in > > __cfg80211_disconnected() > > > > When a connexion was established without going through > > NL80211_CMD_CONNECT, the ssid was never set in the wireless_dev struct. > > Now we set it in __cfg80211_connect_result() when it is not already set. > > > > Reported-by: Yohan Prod'homme <kernel@xxxxxxxx> > > Fixes: 7b0a0e3c3a88260b6fcb017e49f198463aa62ed1 > > Cc: linux-wireless@xxxxxxxxxxxxxxx > > Cc: stable@xxxxxxxxxxxxxxx > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216711 > > Signed-off-by: Marc Bornand <dev.mbornand@xxxxxxxxxx> > > --- > > net/wireless/sme.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > The change log ("changes since v3" etc) should be after "---" line and Does it need another "---" after the change log? something like: "---" "changes since v3:" "(CHANGES)" "---" > the title should start with "wifi: cfg80211:". Please read the wiki link > below. Should i start with the version 1 with the new title? and since i am already changing the title, the following might better discribe the patch, or should i keep the old title after the ":" ? [PATCH wireless] wifi: cfg80211: Set SSID if it is not already set > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
