>-----Original Message----- >From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> >Sent: Tuesday, February 14, 2023 6:18 PM >To: Sriram R (QUIC) <quic_srirrama@xxxxxxxxxxx> >Cc: linux-wireless@xxxxxxxxxxxxxxx >Subject: Re: [PATCH v2] wifi: mac80211: support poll sta for ML clients > >On Fri, 2023-01-20 at 03:42 +0530, Sriram R wrote: >> Update the client probe handling which sends Null data frames to check >> inactivity to support ML Stations as well. >> >> Replace the use of default bss conf with the link specific conf and >> use the stations default link to send the probe frame. Non ML Stations >> associated to the ML AP would use its default link as well which is >> one of the active links. >> >> For Non ML AP, the default link id is 0 and it is taken care as well. > >This seems very wrong. > >It seems like if we have a link here then userspace should pick it. > >But! The station could have disabled that link, for example, after having used >it for association. The station always has the deflink used (unlike vif) but >there's nothing that says that it must actually be active at any given time. > >However that obviously means userspace _cannot_ pick it. > >And then really it means we should address this frame to the MLD and let >driver/firmware pick the right link, and do address translation on it, etc. > >After all, we want to know the MLD is still there, not a specific STA, right? Exactly. It is enough to check if the MLD is active and not specific to any link. But, as you mentioned above its hard to know if polling on the default link is good enough to check MLD is alive.. So the suggestion is to use the link id as UNSPECIFIED and let driver decide to send the null data in any of the active links? Thanks, Sriram.R
