On 17.01.23 10:30, Deren Wu wrote:
From: Neil Chen <yn.chen@xxxxxxxxxxxx>
The rx filter, in mt7921 series, may be changed in fw operation. There is
a racing problem if rx filter controlled by both driver and firmware at
the same time. To avoid this issue, let mt7921 driver set rx filter by new
command MCU_CE_CMD_SET_RX_FILTER and allow the firmware controlling it
only.
Reviewed-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
Co-developed-by: Deren Wu <deren.wu@xxxxxxxxxxxx>
Signed-off-by: Deren Wu <deren.wu@xxxxxxxxxxxx>
Signed-off-by: Neil Chen <yn.chen@xxxxxxxxxxxx>
Somebody on github reported that this patch breaks scanning. After
looking over it once more, I noticed something very odd:
It seems that you are dropping the mac80211 FIF_* -> mt76 filter flags
conversion and passing mac80211 flags to the firmware by using
*total_flags as an argument to mt7921_mcu_set_rxfilter.
This does not make any sense to me.
Shouldn't you leave the existing conversion logic in place, and just
pass the new dev->mt76.rxfilter value to the firmware?
- Felix
