On Thursday, 30 of October 2008, Andrey Borzenkov wrote:
> On Thursday 30 October 2008, Dave wrote:
> > After much faffing about, I managed to bisect this. In retrospect the
> > above hint (thanks Russell) and a code inspection ought to have made the
> > bug obvious. The offending commit is:
> >
> > commit 1168386aa7d850ead2ae135d5a7949a592c6e9a0
> > pcmcia: deprecate CS_OUT_OF_RESOURCE
> >
> > in which the following change is made (among others):
> >
> > @@ -352,7 +352,9 @@ int verify_cis_cache(struct pcmcia_socket *s)
> >
> > buf = kmalloc(256, GFP_KERNEL);
> > if (buf == NULL)
> > - return -1;
> > + dev_printk(KERN_WARNING, &s->dev,
> > + "no memory for verifying CIS\n");
> > + return -ENOMEM;
> > list_for_each_entry(cis, &s->cis_cache, node) {
> > int len = cis->len;
> >
>
> Oh, my ... I have been looking over this dozens of times ... it just
> proves how addictive to bisecting in place of proper debugging we became :(
Bisection is one of debugging techiques and it's as much "proper" as any other
one of them IMO.
> Dave, thank you!
>
> Rafael, this falls in obvious "regression with patches" case I think.
Yes, I added it as http://bugzilla.kernel.org/show_bug.cgi?id=11911 .
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
