Search Linux Wireless

Re: [PATCH v3 0/6] Puncturing support in AP mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/30/2023 12:48 AM, Johannes Berg wrote:
Thanks!

Aloka Dixit (6):
   wifi: nl80211: configure puncturing bitmap in NL80211_CMD_START_AP
   wifi: mac80211: validate and configure puncturing bitmap in start_ap()
   wifi: nl80211: configure puncturing in NL80211_CMD_CHANNEL_SWITCH
   wifi: mac80211: configure puncturing bitmap in channel_switch()
   wifi: cfg80211: add puncturing bitmap in channel switch notifications
   wifi: nl80211: add puncturing bitmap in channel switch events


I feel like maybe you can/should squash 1 and 3, 2 and 4, and 5 and 6?

1/3 are cfg80211 for config, 2/4 are mac80211 for config, and 5/6 are
basically both cfg80211 anyway? Of course 5 updates the users.

And maybe I'd then reorder and put them in this order:

  - new: validation move
  - 1/3
  - 5/6
  - 2/4

so 5/6 just pass 0 from mac80211 to cfg80211_ch_switch_started_notify()
and cfg80211_ch_switch_notify(), and the mac80211 patch (2/4) fills in
the actual values. That way the cfg80211 patch is 'pure' API, no
functionality changes.

What do you think?

johannes

I added separate patches for channel switch because it kept the patches small. No worries, will combine those.

Thanks.



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux