On 1/30/2023 12:40 AM, Johannes Berg wrote:
On Sun, 2023-01-29 at 23:22 -0800, Aloka Dixit wrote:
v3: Validation and storing the bitmap moved to MAC80211.
I think I'd prefer we move the validation function to cfg80211 so both
can use it, this way all potential non-mac80211 drivers have to do it as
well, and then they'll move the function _anyway_ to do the validation
in a single place, I'd hope?
+ u32 punct_bitmap;
Internally I think we can continue to use u16, that's trivial to change
later.
>> + * @NL80211_EXT_FEATURE_EHT_PUNCTURING: Driver supports preamble
puncturing in
+ * EHT.
That should probably make some mention of AP mode? It's not optional in
any way for client, after all, and also not relevant to the API how
client does it.
+
+ *bitmap = nla_get_u32(info->attrs[NL80211_ATTR_PUNCT_BITMAP]) & 0xFFFF;
As the top bits are *reserved* then you should check that they're indeed
zero - now they're ignored, which is generally bad. They might not
always be.
I will address all next version.
Will you be sending another patch which moves validation from mac80211
to cfg80211 or should I add that as the first patch?
