Re: [PATCH v3 3/6] wifi: nl80211: configure puncturing in NL80211_CMD_CHANNEL_SWITCH

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Sun, 2023-01-29 at 23:22 -0800, Aloka Dixit wrote:
> 
> + * @punct_bitmap: Preamble puncturing bitmap. Each bit represents a 20 MHz
> + *	channel with lowest bit corresponding to the lowest frequency. Bit set
> + *	to 1 indicates that the channel is punctured. Higher 16 bits are
> + *	currently unused.

> @@ -1384,6 +1388,7 @@ struct cfg80211_csa_settings {
>  	bool radar_required;
>  	bool block_tx;
>  	u8 count;
> +	u32 punct_bitmap;

again internally I think we can stick to u16 for now

> +++ b/net/mac80211/cfg.c
> @@ -1297,9 +1297,8 @@ static int ieee80211_start_ap(struct wiphy *wiphy, struct net_device *dev,
>  	}
>  
>  	if (params->eht_cap) {
> -		if (!ieee80211_valid_disable_subchannel_bitmap(
> -							&params->punct_bitmap,
> -							params->chandef.width))
> +		if (!ieee80211_valid_disable_subchannel_bitmap(&params->punct_bitmap,
> +							       params->chandef.width))
>  			return -EINVAL;

That got rebased into the wrong patch maybe?

johannes