On Sun, Jan 22, 2023 at 09:31:28PM -0800, Doug Brown wrote: > This series implements two fixes for the libertas driver that restore > compatibility with modern wpa_supplicant versions, and adds (or at least > improves) support for WPS in the process. > > 1) Better handling of the RSN/WPA IE in association requests: > The previous logic was always just grabbing the first one, and didn't > handle multiple IEs properly, which wpa_supplicant adds nowadays. > > 2) Support for IEs in scan requests: > Modern wpa_supplicant always adds an "extended capabilities" IE, > which violates max_scan_ie_len in this driver. Go ahead and allow > scan IEs, and handle WPS based on the info that Dan provided. > > These changes have been tested on a Marvell PXA168-based device with a > Marvell 88W8686 Wi-Fi chipset. I've confirmed that with these changes > applied, modern wpa_supplicant versions connect properly and WPS also > works correctly (tested with "wpa_cli -i wlan0 wps_pbc any"). Thanks, this looks good to me. So, FWIIW, Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
