On Thu, 2023-01-19 at 11:40 -0800, Aloka Dixit wrote: > On 1/18/2023 7:57 AM, Johannes Berg wrote: > > On Wed, 2022-11-09 at 13:47 -0800, Aloka Dixit wrote: > > > FILS discovery and unsolicited broadcast probe response transmissions > > > are configured as part of NL80211_CMD_START_AP, however both stop > > > after userspace uses the NL80211_CMD_SET_BEACON command as these > > > attributes are not processed in that command. > > > > That seems odd. Why would that *stop*? Nothing in the driver should > > actually update it to _remove_ it during change_beacon()? > > > Are you sure you didn't mean to "just" say "however both cannot be > > updated as these attributes ..."? > > > > johannes > > FILS discovery has primary channel, center frequency in the frame format > which should be changed depending on why the beacon changed. Hmm? Sure, the frequency is important, but beacon can change for so many other reasons? Even just the greenfield bit in HT would cause a beacon change as far as cfg80211/mac80211 are concerned. > Hence the > current design, at least ath11k, assumes that BSS_CHANGED_FILS_DISCOVERY > and BSS_CHANGED_UNSOL_BCAST_PROBE_RESP "not being set", when beacon is > changed, means disable these features. > What do you think? I think that makes no sense? If mac80211 didn't clear struct ieee80211_bss_conf::fils_discovery, then surely it should stick around even if the beacon changes??? Surely you can't be right - that'd basically mean the whole feature is useless right now because even the greenfield update or similar that basically *always* happens in hostapd would disable it, since the beacon changes and we don't have these patches? > Should I send a follow-up with a different commit log? > Well seems like we need to first figure out the correct semantics here, and possibly fix things... johannes
