On 19/01/2023 02:25, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> >> Sent: Wednesday, January 18, 2023 9:53 PM >> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx >> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx> >> Subject: Re: [PATCH 1/4] wifi: rtl8xxxu: Register the LED and make it blink >> >> On 18/01/2023 02:52, Ping-Ke Shih wrote: >>> >>> >>>> -----Original Message----- >>>> From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> >>>> Sent: Wednesday, January 18, 2023 6:03 AM >>>> To: linux-wireless@xxxxxxxxxxxxxxx >>>> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx> >>>> Subject: [PATCH 1/4] wifi: rtl8xxxu: Register the LED and make it blink >>>> >>>> If the chip can have an LED, register a struct led_classdev and enable >>>> hardware-controlled blinking. When the chip is not transmitting or >>>> receiving anything the LED is off. Otherwise the LED will blink >>>> faster or slower according to the throughput. >>>> >>>> The LED can be controlled from userspace by writing 0, 1, or 2 to >>>> /sys/class/leds/rtl8xxxu-usbX-Y/brightness: >>>> 0 - solid off. >>>> 1 - solid on. >>>> 2 - hardware-controlled blinking. >>> >>> So, do you like >>> >>> #define RTL8XXXU_HW_LED_BLINKING 2 >>> >> I'm not sure what you mean. Can you elaborate? > > Originally, I would like to replace RTL8XXXU_HW_LED_CONTROL by > RTL8XXXU_HW_LED_BLINKING, because commit messages say "blinking". > After reviewing 2/4, 3/4 and 4/4, I aware that this blinking is > hardware behavior. Then, it becomes hard to me to decide which > name is clear. Anyway, original is fine to me. > Ah, okay. Now I get it. I will keep the original name.
