On Tue, 2022-12-06 at 13:32 +0530, Veerendranath Jakkam wrote:
>
> + * @assoc_link_id: Indicates link ID of the AP MLD link on which (re)association
> + * requested by peer. In non-MLD AP mode, it will be -1. Used only with OWE
> + * update event (driver to user space).
> + * @peer_mld_addr: MLD address of the peer. For non-MLD peer, it will be all
> + * zeros. Used only with OWE update event (driver to user space).
Similar here - why require setting assoc_link_id == -1 if
peer_mld_address can be left zeroes to indicate non-MLO connection?
That'd save you from updating the quantenna driver too, and
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -19776,6 +19776,17 @@ void cfg80211_update_owe_info_event(struct net_device *netdev,
> nla_put(msg, NL80211_ATTR_IE, owe_info->ie_len, owe_info->ie))
> goto nla_put_failure;
>
> + if (owe_info->assoc_link_id != -1) {
> + if (nla_put_u8(msg, NL80211_ATTR_MLO_LINK_ID,
> + owe_info->assoc_link_id))
> + goto nla_put_failure;
> +
> + if (!is_zero_ether_addr(owe_info->peer_mld_addr) &&
> + nla_put(msg, NL80211_ATTR_MLD_ADDR, ETH_ALEN,
> + owe_info->peer_mld_addr))
> + goto nla_put_failure;
> + }
here anyway you have that condition, so you could just lift the
is_zero_ether_addr() to the outer if?
johannes
