Search Linux Wireless

Re: [PATCHv2 5/5] mac80211_hwsim: Make sure beacon_timer gets deleted

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-10-30 at 16:59 +0200, Jouni Malinen wrote:
> plain text document attachment (hwsim_del_timer.patch)
> It was possible to trigger a kernel panic because beacon_timer may not
> have been deleted in all cases when the kernel module was removed while
> hostapd was still running.
> 
> Signed-off-by: Jouni Malinen <jouni.malinen@xxxxxxxxxxx>
> 
> Index: wireless-testing/drivers/net/wireless/mac80211_hwsim.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/mac80211_hwsim.c	2008-10-30 16:11:33.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/mac80211_hwsim.c	2008-10-30 16:26:49.000000000 +0200
> @@ -290,6 +290,7 @@
>  {
>  	struct mac80211_hwsim_data *data = hw->priv;
>  	data->started = 0;
> +	del_timer(&data->beacon_timer);

should that be del_timer_sync, just in case? Not sure how that works
with the rearming thing, I never really understood rearming timers.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux