Search Linux Wireless

Re: [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/16/2023 7:39 PM, Ping-Ke Shih wrote:


-----Original Message-----
From: Doug Brown <doug@xxxxxxxxxxxxx>
Sent: Tuesday, January 17, 2023 4:21 AM
To: Kalle Valo <kvalo@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
<edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>
Cc: Dan Williams <dcbw@xxxxxxxxxx>; Simon Horman <simon.horman@xxxxxxxxxxxx>;
libertas-dev@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Doug Brown
<doug@xxxxxxxxxxxxx>
Subject: [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct

This struct is currently unused, but it will be used in future patches.
Fix the code style to not use camel case.

Signed-off-by: Doug Brown <doug@xxxxxxxxxxxxx>
---
  drivers/net/wireless/marvell/libertas/types.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/libertas/types.h
b/drivers/net/wireless/marvell/libertas/types.h
index cd4ceb6f885d..398e3272e85f 100644
--- a/drivers/net/wireless/marvell/libertas/types.h
+++ b/drivers/net/wireless/marvell/libertas/types.h
@@ -105,7 +105,7 @@ struct mrvl_ie_header {

  struct mrvl_ie_data {
  	struct mrvl_ie_header header;
-	u8 Data[1];
+	u8 data[1];

data[]. see [1]

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays

Hi Ping-Ke,

Thanks for the link. There are several other cases of this same syntax
for flexible trailing arrays in this file, so I will update this patch
in the next version of the series to fix them all.


  } __packed;

  struct mrvl_ie_rates_param_set {
--
2.34.1




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux