On 1/10/2023 8:40 PM, John Keeping wrote:
Hi Arend & all, In linux-firmware, commit 0707b2f ("brcm: add/update firmware files for brcmfmac driver") adds brcm/brcmfmac4339-sdio.bin with version: Firmware: BCM4339/2 wl0: Feb 17 2016 18:29:33 version 6.37.32.RC23.34.42 (r608406) This restores the version previously removed by commit 0f0aefd ("brcm: remove old brcm firmwares that have newer cypress variants"). That was a follow-up to commit 04f71fe ("cypress: add Cypress firmware and clm_blob files") which provides cypress/cyfmac4339-sdio.bin and links it (via WHENCE) to brcm/brcmfmac4339-sdio.bin and has version: Firmware: BCM4339/2 wl0: Sep 5 2019 11:05:52 version 6.37.39.113 (r722271 CY) It looks like the same also applies to a few other firmware, although I don't have the hardware to check the relevant versions there. Should part of 0707b2f ("brcm: add/update firmware files for brcmfmac driver") be reverted in favour of the files in cypress/? (It looks like these will already be used due to the order of the file so the symlinks to cypress/... will overwrite files installed from brcm/...)
Thanks, JohnGuess I have to be extra careful these days with all companies submitting firmware patches. I will need to inspect the history per file and see what needs to be reverted and what not. Unfortunately the firmware updates were done in one commit. I look into it. Thanks again.
Regards, Arend
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature